This repository was archived by the owner on Jun 12, 2023. It is now read-only.
Open
Conversation
meandavejustice
requested review from
BeroBurny,
irubido and
mpetrunic
as code owners
|
|
Deploying with
|
| Latest commit: |
6797300
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea4f89f3.filsnap.pages.dev |
| Branch Preview URL: | https://update-lotus.filsnap.pages.dev |
meandavejustice
force-pushed
the
update-lotus
branch
from
5567305 to
0b3a9d1
Compare
hugomrdias
suggested changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updated
packages/snap/@types/lotus-client-schema/index.d.tsfile is big, it's the generated types from https://github.com/filecoin-shipyard/js-lotus-client-schema. I feel like there should be a better way for these to either be imported or installable in a different way from npm. Open to suggestions.